fix #89 with Image component v2.0 + 23 tests #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously these tests would fail if they ran before qtbot was initialized by another test. I'm now running tests in a random order
one step towards fixing #89
previous commit did most of it but this polishes the GUI - fixes #89
3 resize modes are scale, cover, and stretch. Scale only applies when resizeMode is set to scale. Cover uses ImageOps.fit() to stretch while maintaining aspect ratio. Also, spinBox_scale was moved to be underneath comboBox_resizeMode.
the purpose is to allow easier reuse in other components
this causes the image to scale up and down slightly based on the input audio file
Collaborator
Author
|
I added another option to scale the image up and down slightly in response to the input audio file, so you can use the Image component as a visualizer now. This is a similar effect to some videos I've seen where the creator pulses their avatar in response to the audio. |
increases rendering speed of a 1-minute video by 12 seconds (based on two manual tests anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the second scale spinbox from the Image component for reasons I wrote about here, which means I should change the version number since the saved settings are different now. Since I'm doing that anyway, might as well improve the settings to make a bit more sense.
In this pull request the Image component widget is changed to this:
And selecting a different resize mode disabled the scale spinbox:
Now as well as scale and stretch, we have a third option "cover" that makes the image fit without distorting its aspect ratio. This seems a bit more useful than the previous options.
I also wrote tests for some toolkit functions, undoing component updates, and some specific methods of 3 components (classic visualizer, image, and title text). While doing this I fixed two incorrect comments and replaced numpy.seterr with a context manager version
I will merge this late tomorrow unless I discover problems with it or someone has objections